Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device base classes should save class attributes in device/connection table properties #29

Open
philipstarkey opened this issue Oct 30, 2018 · 0 comments
Labels
enhancement New feature or request minor

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


We should save all of the device attributes if they are relevant down stream. For example, things like clock_resolution, wait_delay, trigger_delay, etc. of PseudoclockDevices should be stored so that they can be accessed by runmanager. I think these should probably be stored in the device properties in the base class definitions (PseudoclockDevice and IntermediateDevice), leaving it up to the device class maintainer to decide if they should also be saved in the connection table properties (which would force connection table recompilation and prevention of old shots from being re-run if something in the class was updated).

runviewer and BLACS would then access this information rather than relying on the labscript using the same version of the device class, with the same parameters, as runviewer and BLACS (which could even be running on separate PC's)

@philipstarkey philipstarkey added minor enhancement New feature or request labels Apr 5, 2020
Loki27182 pushed a commit to Loki27182/labscript-devices that referenced this issue Oct 9, 2023
…l request labscript-suite#29)

Configurable trigger slope for the timeout trigger device of a wait monitor

Approved-by: Chris Billington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

1 participant