Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis results groupname does not reflect full filename if the filename contains ".py" somewhere in the middle #83

Open
philipstarkey opened this issue Nov 5, 2020 · 0 comments

Comments

@philipstarkey
Copy link
Member

Bit of a "This will probably never happen" issue, but we get the result groupname (in the Run class) by splitting on .py and taking the zeroth element. This obviously returns unexpected results if there is more than one .py in the filename.

Fixing it is "tricky" in that it changes behaviour that has existed for sometime. We should probably (for lyse v3.x) detect and warn if there are multiple .py in the filename and state that this will change in v4. Ideally we would also give a path to utilise the v4 fix sooner (but that seems difficult).

To be honest, we should maybe have a bigger discussion about how the groupname matching just the filename, and ignoring the folder names, is less than ideal as you have to ensure you have unique filenames across all scripts in analysislib, even if they are organised in different folders.

@philipstarkey philipstarkey mentioned this issue Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant