Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor by adding a tick type to replace i32 for ticks #52

Open
rcatalan98 opened this issue Aug 29, 2023 · 0 comments
Open

Refactor by adding a tick type to replace i32 for ticks #52

rcatalan98 opened this issue Aug 29, 2023 · 0 comments
Labels
refactor
Milestone
YAS-v0

Comments

@rcatalan98
Copy link
Collaborator

Currently there are no verifications that the ticks received are between the tick range defined in int24 in solidity. We should consider adding a tick type using i32 and adding a check or verifying always tick is used correctly.
@rcatalan98 rcatalan98 added this to the YAS-v0 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
YAS-v0
Development

No branches or pull requests
1 participant
@rcatalan98