Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Non-native ERC20 bridge integration tests #58

Closed
jrchatruc opened this issue Jan 18, 2024 · 0 comments
Closed

Fix Non-native ERC20 bridge integration tests #58

jrchatruc opened this issue Jan 18, 2024 · 0 comments
Assignees
@SantiagoPittella
Labels
erc20-base-token

Comments

@jrchatruc
Copy link
Member

🌟 Feature Request

📝 Description

These tests are currently broken, as a lot of the logic for the ERC20 bridge contracts was quickly hardcoded to make it compile but is not correct. The deposit function for the L1ERC20Bridge.sol contracts should take an extra parameter that acts as the "msg.value" field in the case of a ZK stack with an ERC20 as its native token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SantiagoPittella SantiagoPittella

Labels
erc20-base-token
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Non native tokens integration test lambdaclass/zksync-era
2 participants
@jrchatruc @SantiagoPittella