Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some tests for #6499 #21

Closed
weierophinney opened this issue Dec 31, 2019 · 1 comment
Closed

Added some tests for #6499 #21

weierophinney opened this issue Dec 31, 2019 · 1 comment
Assignees
Labels
Bug Something isn't working

Comments

@weierophinney
Copy link
Member

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/6503
User: @rahuldroy
Created On: 2014-07-31T14:24:38Z
Updated At: 2015-05-07T13:37:25Z
Body


Comment

User: @Ocramius
Created On: 2014-07-31T15:11:25Z
Updated At: 2014-07-31T15:11:25Z
Body
Linking #6499


Comment

User: @weierophinney
Created On: 2014-08-07T16:42:14Z
Updated At: 2014-08-07T16:42:14Z
Body
@Ocramius is this an issue specific to our annotation support, or is it an issue in the Doctrine annotation library?


Comment

User: @Ocramius
Created On: 2014-08-07T16:49:09Z
Updated At: 2014-08-07T16:49:09Z
Body
Still not clear. I personally think Zend\Code may be passing a different string to the annotation parser.


Comment

User: @weierophinney
Created On: 2014-08-07T17:04:10Z
Updated At: 2014-08-07T17:04:10Z
Body
Removed milestone, as we cannot reliably reproduce.

In discussion with @Ocramius, it's possible that Zend\Code is passing an invalid string to the annotation parser. In looking at Zend\Code\Reflection\ClassReflection, however, the method we call is getAnnotations(), which passes the results of getDocComment() -- which is inherited directly from ReflectionClass. As such... this is very difficult to track.


Comment

User: @nickurt
Created On: 2014-08-08T08:45:05Z
Updated At: 2014-08-08T08:45:05Z
Body
@weierophinney @Ocramius Thanks for the reply's, I debugged some things.

The file Zend\Code\Scanner\AnnotationScanner -> __construct returns the correct docComment, but it fails in the tokenize function (#ref).

The currentChar (#ref) is here ...

string(1) "/"
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "

Comment

User: @Ocramius
Created On: 2014-11-19T22:24:09Z
Updated At: 2014-11-19T22:24:09Z
Body
I see that this has indeed nothing to do with doctrine/annotations. Removing myself from the assignees as I cannot help with this issue right now.


Comment

User: @Maks3w
Created On: 2015-05-07T13:37:25Z
Updated At: 2015-05-07T13:37:25Z
Body
Do zendframework/zendframework#7113 fix this?



Originally posted by @GeeH at zendframework/zend-code#79

@Ocramius
Copy link
Member

Closing here: the annotation support in laminas/laminas-code is long gone (in 3.x)

@Ocramius Ocramius added the Bug Something isn't working label Nov 30, 2020
@Ocramius Ocramius self-assigned this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants