Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools require a filled description #336

Open
efriis opened this issue Jan 23, 2025 · 1 comment
Open

tools require a filled description #336

efriis opened this issue Jan 23, 2025 · 1 comment
Labels
bedrock bug Something isn't working

Comments

@efriis
Copy link
Member

efriis commented Jan 23, 2025

Generally langchain tools default to having an empty string as a description. Some (maybe all) bedrock models require a filled description, which affects the ease of use of with_structured_output(method="function_calling") and bind_tools with ChatBedrock

In particular, this impacts model interoperability, where people are trying their tools with different models, and the bedrock versions simply fail.

Some ideas:

  • populate the description with the same as the tool name by default in bedrock to avoid the error
  • raise a more descriptive error to help people populate docstrings on their tool function/basemodel/etc

I'm probably more in favor of auto populating for models this impacts

cc @hinthornw

@3coins 3coins added bug Something isn't working bedrock labels Jan 23, 2025
@3coins
Copy link
Collaborator

3coins commented Jan 23, 2025

cc @patilvishal0597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bedrock bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants