Updates MongoDBGraphStore.__init__ signature #83
Conversation
| "db.create_collection.(coll_name, validator={'$jsonSchema': schema.entity_schema})" | ||
| ) | ||
| else: | ||
| client: MongoClient = MongoClient( |
There was a problem hiding this comment.
We can't assume that the collection doesn't already exist just because we're creating the client.
There was a problem hiding this comment.
@blink1073 This is inside a warning message.
There was a problem hiding this comment.
My question is: if the collection already exists, what is the behavior here?
There was a problem hiding this comment.
Actually, I see what happens now. There would be no validation added. I think we need to always attempt to add validation.
There was a problem hiding this comment.
We do attempt. It's in a try/except block. Let's discuss on slack if we want to delay release of a version for this.
There was a problem hiding this comment.
We do not attempt for a collection that already exists, which may have been created by the user, no?
|
Link to a new passing patch after additional cases of adding validation |
Update signature of constructor to remove positional arguments, allows one of collection, or connection_string, database_name, and collection_name.
Link to a passing patch