Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing arguments to Ngrok broken in v.4.8.0 #1494

Open
kiritokatklian opened this issue Sep 11, 2024 · 2 comments · May be fixed by #1495
Open

Passing arguments to Ngrok broken in v.4.8.0 #1494

kiritokatklian opened this issue Sep 11, 2024 · 2 comments · May be fixed by #1495

Comments

@kiritokatklian
Copy link

Description

v4.8.0 breaks passing arguments like --domain with the valet share command. Only tested with Ngrok.
For now I've downgraded back to v4.7.1, since it works in this version

Steps To Reproduce

$ valet share-tool ngrok
$ valet share --domain=custom.domain

Diagnosis

N/A
@drbyte
Copy link
Contributor

drbyte commented Sep 15, 2024

Could be related to #1467
/cc @rcknr

@rcknr
Copy link
Contributor

rcknr commented Sep 15, 2024

It seems like this line has to have != instead of ==.

rcknr added a commit to rcknr/valet that referenced this issue Sep 16, 2024
@rcknr
Fix extra parameters for share tool, laravel#1494
cd3fbb0
@rcknr rcknr linked a pull request Sep 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix extra parameters for share tool, fixes #1494 rcknr/valet
3 participants
@drbyte @rcknr @kiritokatklian