Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Collect only from tagged files (TODOs from 4000 markdown files in (27.085s)`) #87

Open
gerroon opened this issue Dec 8, 2023 · 4 comments

Comments

@gerroon
Copy link

gerroon commented Dec 8, 2023

Hi

This plugin is great but not so great with large vaults

[obsidian-plugin-todo] Parsed 30 TODOs from 4000 markdown files in (27.085s)

It would be great if it can limit the search to tagged files like "#todo" etc. Maybe that can improve the load times.

@larslockefeer
Copy link
Owner

Hey @gerroon, thanks for reaching out. I'm sorry to hear that the plugin is slow for you.

I've been trying to investigate this a bit by generating data for a large vault (containing 4000 files of varying size with over 8000 TODOs, measuring ~180 MB in total) and using my plugin on that vault, but I don't really notice big performance issues:

  • The parsing takes just 2.7 seconds
  • Obsidian and the plugin are running just fine

In order to help me reproduce the problem locally, can you maybe share a little more information about:

  • The system you are using (operating system, memory)?
  • Characteristics of your vault? What is the total size of your vault in megabytes?

This will help me find a local reproduction scenario to test performance improvements I might be able to add.

Thanks a lot!

@gerroon
Copy link
Author

gerroon commented Jan 7, 2024

Are you on an SSD? My vault is on a regular 5400 RPM USB drive. I also use a lot of folders in my vault.

I use Windows 11, 64GB ram, Intel I9 desktop.

@larslockefeer
Copy link
Owner

Ah, that makes sense. I'm on an SSD indeed.

Is it just the initial load that is slow, or is Obsidian afterwards also performing sluggishly when the plug-in is running in your case?

@gerroon
Copy link
Author

gerroon commented Jan 7, 2024

I think it is the initial parsing. Please see the first post, that is from the DevTools. The sluggishness happens around the time the log is printed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants