Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TotalSegmentor is launched as a blocking process #10

Open
BishopWolf opened this issue Jan 12, 2023 · 1 comment
Open

TotalSegmentor is launched as a blocking process #10

BishopWolf opened this issue Jan 12, 2023 · 1 comment

Comments

@BishopWolf
Copy link

TotalSegmentor is launched as a blocking process that hangs Slicer for several minutes. It shall be remade as a process with progress bars. I think this is self explanatory.

@lassoan
Copy link
Owner

lassoan commented Jan 16, 2023

I don't plan to work on this but it would be nice if you could make this change.

The segmentation already runs in a separate process, so probably all the logic change you is to replace the while loop in logProcessOutput by a timer callback. Make the blocking/non-blocking behavior selectable by adding a waitForCompletion argument (=True by default) to the in process method. Blocking mode is required for batch processing and makes things simpler when the logic is used from other modules.

The GUI need to be tuned a bit, too: remove the override cursor, add some kind of a progress bar (it is not trivial to determine an accurate progress from the process output), and turn the Apply button to Cancel button while the segmentation is running (clicking it will terminate the process).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants