Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack implementation #130

Closed
cescoferraro opened this issue Aug 13, 2016 · 1 comment
Closed

webpack implementation #130

cescoferraro opened this issue Aug 13, 2016 · 1 comment

Comments

@cescoferraro
Copy link

Its official, Ionic is shifting to Webpack. This repo will become obsolete over time if it keeps using browserify.

I have been trying but keep getting errors with @angular/testing

@lathonez
Copy link
Owner

Thanks for raising. I am aware of this, it was also raised here earlier.

What's requirement for implementing Webpack before beta.12 has been released? I may be able to help you with Karma (will reply on Ionic forum), but am not interested in making any changes here before Ionic do.

As a bit of history, this repo has been around since the very early days of Ionic 2 and we've always followed their build configuration as closely as possible:

  • gulp (calling tsc directly)
  • webpack (via gulp)
  • ionic-app-lib (webpack wrapper, via gulp)
  • browserify

If the new Webpack build is indeed released in beta.12, we'll be able to get a look at their implementation and mirror it as closely as possible for the test build.

If we try to implement anything before that there's a good chance we'll end up reworking the change to bring us closer to Ionic.

TL;dr - as soon as Ionic release a new build process, I'll move this over to mirror it as closely as possible, not before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants