Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play-dl support #534

Open
getxd-dev opened this issue Oct 6, 2021 · 6 comments
Open

Play-dl support #534

getxd-dev opened this issue Oct 6, 2021 · 6 comments

Comments

@getxd-dev
Copy link

Use play-dl for extracting YT videos.

https://www.npmjs.com/package/play-dl

@Ryan5453
Copy link
Contributor

Ryan5453 commented Oct 6, 2021

I seriously doubt Lavalink will ever switch from Lavaplayer because the whole purpose is to provide a separate Lavaplayer node. Besides that, it wouldn’t work anyway seeing that’s an npm package and Lavalink is written in either java or kotlin (i forget)

@freyacodes
Copy link
Member

I'm not opposed to having multiple downloader libraries. The big issue is that play-dl is a JS library which is difficult to integrate into a JVM application like Lavalink. It might be possible with something like GraalVM, but that would require users to switch to that specific JVM.

https://www.graalvm.org/reference-manual/js/JavaInteroperability/

The downloaded audio would then go through Lavaplayer to be processed.

Significant changes would have to be made to Lavalink to make all of this possible.

Lavalink is written in either java or kotlin (i forget)

Both! They are interoperable JVM languages.

@freyacodes freyacodes changed the title Lavalink Suggestion Play-dl support Oct 6, 2021
@DaliborTrampota
Copy link
Contributor

check this out https://github.com/AmandaDiscord/Volcano its 1:1 replacement for lavalink which runs on js and ytdl. It mirrors the lavalink api so no code needs to be rewritten

@PapiOphidian
Copy link
Contributor

would not recommend tbh

@Fyphen1223
Copy link
Contributor

play-dl is basically unstable through my experience. I cannot be so sure that changing downloader to Node.js based library will improve the quality of Lavalink.

@madebylydia
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants