Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

event names for searchEntry && searchReference are 'broken' #765

Closed
hillar opened this issue Oct 25, 2021 · 2 comments
Closed

event names for searchEntry && searchReference are 'broken' #765

hillar opened this issue Oct 25, 2021 · 2 comments

Comments

@hillar
Copy link

hillar commented Oct 25, 2021

let event = msg.constructor.name

if constructor.name is not same as instanceof events will get 'wrong name'

hillar added a commit to hillar/node-ldapjs that referenced this issue Oct 25, 2021
 match event name to `instanceof`, not to `constructor.name`
hillar added a commit to hillar/node-ldapjs that referenced this issue Oct 25, 2021
@UziTech UziTech linked a pull request Oct 26, 2021 that will close this issue
@roubert
Copy link

roubert commented Nov 2, 2022

This issue can cause real problems when using a module bundler such as rollup.js, which can cause these classes to be renamed to names that no longer correspond to the event names that should be used, thereby breaking any code that expects ldapjs to produce these event names as documented.

The linked pull request looks good to me, it solves the problem that I've encountered.

@jsumners
Copy link
Member

👋

On February 22, 2023, we released version 3 of this library. As a result, we are closing this issue/pull request.

Please see issue #839 for more information, including how to proceed if you feel this closure is in error.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants