Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create colours story in Storybook #73

Open
seagyn opened this issue Oct 16, 2019 · 4 comments
Open

Create colours story in Storybook #73

seagyn opened this issue Oct 16, 2019 · 4 comments
Labels
good first issue Good for newcomers Hacktoberfest

Comments

@seagyn
Copy link
Contributor

seagyn commented Oct 16, 2019

Would be helpful to add a colour reference in storybook. Example: https://www.figma.com/file/bUBZY5aVyXYdedy2wCtDxr/Oxygen-Core?node-id=1%3A6500

It basically needs to show the colour group, the name and the actual hex value.

Screenshot 2019-10-16 at 10 10 49

Bonus points for showing RGB value as well.
@benfluleck
Copy link

I can have a look at this

@seagyn
Copy link
Contributor Author

seagyn commented Oct 16, 2019

Thanks. The colours are being updated at the moment so what for #72 to be merged.

@seagyn
Copy link
Contributor Author

seagyn commented Oct 24, 2019

Hi there, colours have been merged. You can have a look and open a PR against v2 if you're still interested!

@benfluleck
Copy link

lol that took a while, Can start next week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seagyn @benfluleck