Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing account manage page QSD breaks the teacher bio link #3819

Open
willgearty opened this issue Feb 4, 2025 · 0 comments
Open

Editing account manage page QSD breaks the teacher bio link #3819

willgearty opened this issue Feb 4, 2025 · 0 comments
Assignees
Labels

Comments

@willgearty
Copy link
Member

If you edit the QSD here...

{% inline_qsd_block "contact_password_recovery_check" %}
<h2>You can do the following things with your account:</h2>
<center>
<ul class="nav nav-tabs nav-stacked">
<li style="width: 50%;"><a href="/myesp/profile" title="Edit your profile" style="text-decoration: none;">Edit your profile</a></li>{% if request.user.isTeacher %}
<li style="width: 50%;"><a href="/teach/teachers/{{ request.user.username }}/bio.edit.html" title="Edit your teacher biography" style="text-decoration: none;">Edit your teacher biography</a></li>
{% endif %}<li style="width: 50%;"><a href="/myesp/passwd" title="Change your password" style="text-decoration: none;">Change your password</a></li>
<li style="width: 50%;"><a href="/myesp/disableaccount" title="Disable your account" style="text-decoration: none;">Disable your account</a></li>
</ul>
</center>
<p>Please note, if you disable your account, you will no longer receive email and/or mail notifications from us.</p>
{% end_inline_qsd_block %}

...it ends up converting the teacher bio link into a fixed link (usually the link to the bio of the admin who is editing the QSD)

I think there are two possible solutions for this:

  1. Modify the QSD to have the editable text underneath these buttons (which probably shouldn't be editable in the first place).
  2. Create a new view/url redirect that is the same for all users (e.g., /teach/bio) that then redirects to that user's biography for editing
@willgearty willgearty added the QSD label Feb 4, 2025
@willgearty willgearty added this to the Stable Release 16 fixes milestone Feb 4, 2025
@willgearty willgearty self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant