Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create formalized tests #22

Open
glormph opened this issue Aug 30, 2023 · 1 comment
Open

Create formalized tests #22

glormph opened this issue Aug 30, 2023 · 1 comment

Comments

@glormph
Copy link
Member

glormph commented Aug 30, 2023

I run a battery of tests, but they are a bit loose and not defined in the repo. Need to create some proper tests, can even think about running on github actions if they can be fast enough.

Test checklist to be added to:

  • at least a TIMS-TOF run
  • Own MSGF modification spec
  • different quant summarizations types (sweep, multi denom)
  • DEqMS OK and Fail (single ch)
  • LF / isobaric x Phos, Acetyl, GG x with totalprotnorm
  • files and set names with weird characters (spaces, special char, start with a number, etc) that need quoting, or are disliked by R and maybe percolator?
  • complement runs with added/exchanged sets (don't forget PTMs)
  • no quant, no MS1 quant
  • using old SQLite lookup
  • different warnings, not enough PSMs, peptides, etc

Also important:

  • Make sure there is output, double check if e.g. luciphor actually runs, or maybe it needs more PSMs.
  • Small test data, so probably crappy conf lvls but that is fine.
@glormph
Copy link
Member Author

glormph commented Dec 11, 2023

Tests have been defined and can be run locally from the run_tests.sh script. But, output of runs is not verified yet! This is kind of important unless you want to check all QC output yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant