feat(metrics): Add rest of master chartdata metrics #152
Conversation
There was a problem hiding this comment.
Very good job @uristdwarf 👍 🔥 🚀
I added some minor suggestions to improve readability and other aspects, but they are not stoppers for merging.
uristdwarf
force-pushed
the
prometheus-two
branch
2 times, most recently
from
5ee28e1 to
d7b266a
Compare
For new libraries, I think we are not adding it but for existing/refactored ones we are |
uristdwarf
dismissed stale reviews from ralcolea and lgsilva3087
via
455fd60
uristdwarf
force-pushed
the
prometheus-two
branch
from
455fd60 to
e768efb
Compare
uristdwarf
force-pushed
the
prometheus-two
branch
from
e768efb to
a2e9778
Compare
uristdwarf
force-pushed
the
prometheus-two
branch
from
a2e9778 to
b805df5
Compare
Maybe this kind of decisions should be communicated to all devs. |
uristdwarf
force-pushed
the
prometheus-two
branch
3 times, most recently
from
233bc13 to
9fe8614
Compare
uristdwarf
force-pushed
the
prometheus-two
branch
2 times, most recently
from
1a87bce to
da455ba
Compare
There was a problem hiding this comment.
Great job @uristdwarf 👍 🔥 🚀
I shared some minor suggestions for your consideration, but none of them are stoppers to merge.
However, I had compilation errors when building the project without installing prometheus-cpp-dev package. Can you confirm whether this scenario works as expected?
uristdwarf
dismissed stale reviews from ralcolea and lgsilva3087
via
83fd218
uristdwarf
force-pushed
the
prometheus-two
branch
4 times, most recently
from
c2e4813 to
3a94d51
Compare
uristdwarf
force-pushed
the
prometheus-two
branch
2 times, most recently
from
a8e4f04 to
3d16686
Compare
This commit finishes adding metric data from master chartsdata. Since all the chartsdata was counters in Prometheus terminology, there was no need to add other types, however a a small refactor was needed to accomodate master metrics and in the future other service metrics. Notably removed was CPU usage and memory, since there are better ways to gather this data, including with a prometheus server itself (which will scrape this data). This commit deprecates master chartsdata, and is the first step in deprecating the CGI monitoring Signed-off-by: Urmas Rist <[email protected]>
Specifically, it checks that the master operations are working Signed-off-by: Urmas Rist <[email protected]>
Previously it required you to have the library installed on the system. Using FetchContent in CMake, it is now acquired externally if the CMake config does not exist on the system and the build option is correctly set (which it is by default). This will statically compile the library into the binary. Signed-off-by: Urmas Rist <[email protected]>
uristdwarf
force-pushed
the
prometheus-two
branch
from
3d16686 to
cb8e3f2
Compare
This commit finishes adding metric data from master chartsdata. Since all the chartsdata was counters in Prometheus terminology, there was no need to add other types, however a a small refactor was needed to accomodate master metrics and in the future other service metrics. Notably removed was CPU usage and memory, since there are better ways to gather this data, including with a prometheus server itself (which will scrape this data).
This commit deprecates master chartsdata, and is the first step in deprecating the CGI monitoring