Add saunafs command on Windows #298
Open
+810
−322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolysr
requested review from
uristdwarf,
lgsilva3087,
ralcolea,
antuan96314,
ictus4u and
dmga44
rolysr
force-pushed
the
add-saunafs-command-on-windows
branch
3 times, most recently
from
34eaa8d to
add65ff
Compare
dmga44
reviewed
Feb 13, 2025
There was a problem hiding this comment.
Great work! 👍
As a general comment, I think the changes would have looked better if they were ordered like:
- enough to be able to compile in Windows
- fixes on
open_master_connfunction, including the changes in the protocol. - fixes on each of the tools, single commit or multiple commits, as you see fit.
Though it would be a chore to make it that way now.
rolysr
force-pushed
the
add-saunafs-command-on-windows
branch
3 times, most recently
from
a77b983 to
3d8551c
Compare
rolysr
force-pushed
the
add-saunafs-command-on-windows
branch
5 times, most recently
from
7542b86 to
b72a05c
Compare
For making the saunafs command available on Windows, this commit adds the necessary changes to compile the saunafs command on Windows. Signed-off-by: rolysr <[email protected]>
The `open_master_conn` function was not working properly on Windows when using it with the saunafs tool because it was not properly resolving the inode by a given path on the file system. This commit fixes that issue. Signed-off-by: rolysr <[email protected]>
The makesnapshot command was failing on saunafs tool on Windows because of not correctly resolving the source inode from which the snapshot was going to be created. This commit fixes that issue. Signed-off-by: rolysr <[email protected]>
The previous implementation of recursive remove was not correctly delimiting the path separator for a parent path from a given full path when using the saunafs tool on Windows. This commit fixes that issue. Signed-off-by: rolysr <[email protected]>
Signed-off-by: rolysr <[email protected]>
Previous version of saunafs tool was not properly resolving a given inode from a path when using it in a Windows client mountpoint with the `sfsmountingsubfolder` option enabled. This commit fixes that issue. Signed-off-by: rolysr <[email protected]>
This commit allows to test the saunafs.exe tool generated for Windows in the testing framework. Signed-off-by: rolysr <[email protected]>
rolysr
force-pushed
the
add-saunafs-command-on-windows
branch
from
b72a05c to
853339c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the corresponding integration of the saunafs tool on a Windows environment. The main changes were:
open_master_connfunction in order to correctly get the corresponding inode from a given Windows file system path.makesnapshotandrremoveto work on Windows.