FAB artifact on click when using com.google.android.material:material:1.1.0

[mbfakourii]

Hi this library is having a problem at Ripple
This is a problem when we click on the fab button
See the picture below to find out

[leinardi]

Please provide all the information required when you open a bug report:

• Library version: ?
• Android version: ?
• Support library version: ?
• Device brand: ?
• Device model: ?

[mbfakourii]

Library version: 3.1.1
Android version: API 21 Android 5.1.1
Support library version: Use AndroidX Verison appcompat:1.1.0 And material:1.1.0
Device brand: Huawei
Device model: huawei p7-l10

[mbfakourii]

For better Test change Color overlay to black !

[leinardi]

I can reproduce the issue using com.google.android.material:material:1.1.0 but it seems already fixed on version com.google.android.material:material:1.2.0-alpha04.

I can't do anything about this since it's a bug of the google material library. My advice is to use the version 1.2.0-alpha04 if you can or don't use the material library at all.

[mbfakourii]

i use material:1.2.0-alpha04 But the problem was not solved

[mbfakourii]

if google material library has bug Why this is ok ?
https://material.io/develop/android/components/floating-action-button/

i use both lib FloatingActionButtonSpeedDial and floating action button in the my project but only FloatingActionButtonSpeedDial has bug !

[drakeet]

Don't use paddingCompat can fix this. I am using this library in my app Pure Writer, and got the same bug on Android 5.1.1, I finally fixed it by using real margins and no clips.

[drakeet]

This bug can be reproduced on Android 5.1.1 emulator/AOSP ROM.

[mbfakourii]

@drakeet

Should this line be deleted?

https://github.com/leinardi/FloatingActionButtonSpeedDial/blob/release/library/src/main/java/com/leinardi/android/speeddial/SpeedDialView.java#L766

[drakeet]

Yes, it's the cause.

[mbfakourii]

The bug will be solved
but
This is what it looks like

[mbfakourii]

Items have the same bug :|

[mbfakourii]

@leinardi help :(

[BrightVan]

you can try this:

public static void fixSpeedDialFab_5_x(@NonNull SpeedDialView speedDialView) {
        if (Build.VERSION.SDK_INT > 22 || Build.VERSION.SDK_INT < 21) {
            return;
        }
        speedDialView.getMainFab().setRippleColor(Color.TRANSPARENT);
        Class speedDialViewClass = speedDialView.getClass();
        try {
            Field fabWithLabelViewsField = speedDialViewClass.getDeclaredField("mFabWithLabelViews");
            fabWithLabelViewsField.setAccessible(true);
            Object targetObject = fabWithLabelViewsField.get(speedDialView);
            if (targetObject instanceof List) {
                List<FabWithLabelView> fabWithLabelViews = (List<FabWithLabelView>) targetObject;
                if (!fabWithLabelViews.isEmpty()) {
                    for (FabWithLabelView fabWithLabelView : fabWithLabelViews) {
                        fabWithLabelView.getFab().setRippleColor(Color.TRANSPARENT);
                    }
                }
            }
        } catch (Exception e) {
            e.printStackTrace();
        }
    }

[mbfakourii]

@BrightVan
this code remove ripple :( and not work for items

[BrightVan]

@BrightVan
this code remove ripple :( and not work for items
the ripple effect is just fab bg become deeper when pressed.
of cource the code remove ripple.there is no other way to solve the problem quickly and compat. it's better than there show a strange ripple when pressed on api 22.
and what is the 'not work for items' means？the reflection code is for what ?

[drakeet]

I have provided the exact solution:

Don't use paddingCompat can fix this. I am using this library in my app Pure Writer, and got the same bug on Android 5.1.1, I finally fixed it by using real margins and no clips.

Remove FAB setUseCompatPadding(~~true~~) and use params.setMargins(padding, padding, padding, padding) instead. In the same time, setClipChildren(false)) in its parent view.

I am sorry, I made a lot of local changes to this library, so I can’t create a PR or share related code directly. But I can take a screenshot for the source code:

(You can see my app for the performance result https://play.google.com/store/apps/details?id=com.drakeet.purewriter)

[stale]

This issue has been automatically marked as stale because it has not had activity in the last 60 days.