-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threshold in arcface loss #117
Comments
I really appreciate your effort but when I calculate cos(theta+margin) manually, I found that the first plot is correct and I think mathematically, the second plot is wrong as the cos of any angle should be within [-1, 1] but it exceeds -1. |
Ya, if feed back into cos, it's not correct, Just this value here will multiply with |
In arcface loss a certain threshlod is used: theta_valid = tf.where(y_pred_vals > self.threshold, theta, self.theta_min - theta). I didn't understand why we should use this threshold, how to determine its value and finally if we violet the threshold we set the value to 'self.theta_min - theta' based on what this value is chosen? Thanks in advance.
The text was updated successfully, but these errors were encountered: