Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive containing archive which overwrites other archive #11

Open
micke opened this issue Jan 2, 2018 · 4 comments
Open

Archive containing archive which overwrites other archive #11

micke opened this issue Jan 2, 2018 · 4 comments
Labels

Comments

@micke
Copy link

micke commented Jan 2, 2018

I've come upon a pretty annoying edge-case where a torrent contains two archives.
The first archive is an archive with the subtitles and a nested archive within itself.
The second archive is an archive of the movie.
Because unrar is run with -o+ the movie archive gets overwritten resulting in the movie being lost.

Best illustrated like this:

  • ubuntu-subs.rar
    • ubuntu.srt
    • ubuntu.rar
  • ubuntu.rar
    • ubuntu.mkv
  • ubuntu.r00
  • ubuntu.r01
    ...

The big question is why would someone do it like this and i don't really have an answer to that but it has happened to me enough times to be a problem.

One way to resolve this would be to run unrar with the -or flag which renames files that would otherwise overwrite another file. In the above example ubuntu.rar would become ubuntu (1).rar

As for the other commands i haven't really looked into alternatives to rename instead of overwrite.

@levic92
Copy link
Owner

levic92 commented Jan 17, 2018

That is strange that someone would create an archive like that. I haven't run into any torrents that do this yet. Thank you for reporting the issue, I will look into it when I have some extra time

@micke
Copy link
Author

micke commented Jan 17, 2018

Yeah, really strange and really annoying. Took me a while to understand why half of my downloads failed. Apparently a lot of torrents on torrentleech are like that...

In the meantime i've been running my fix without any issues from here micke@cf82430.
It's only fixed for rars though.

@dabear
Copy link

dabear commented Nov 18, 2018

I hit this problem as well today. I had to disable the plugin, recheck+download and manually extract as a workaround. Will try micke's fix now. I can provide an example torrent if contacted privately on gitter. Running on linux

@arcmodo
Copy link

arcmodo commented Jan 23, 2019

I'm seeing this as well. It's extremely frustrating. I'll try micke's fix as well until we see something from @levic92 (great plugin, by the way!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants