Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexik:currency:import yahoo not working #54

Open
medevphp opened this issue Nov 3, 2017 · 7 comments
Open

lexik:currency:import yahoo not working #54

medevphp opened this issue Nov 3, 2017 · 7 comments

Comments

@medevphp
Copy link

medevphp commented Nov 3, 2017

lexik:currency:import yahoo not working
Seems like yahoo has discontinued the service.

Digging deeper, found the following response from their API :

It has come to our attention that this service is being used in violation of the Yahoo Terms of Service. As such, the service is being discontinued. For all future markets and equities data research, please refer to finance.yahoo.com.

@jdambacher
Copy link
Contributor

You're right! I will search for another service providing worldwide currency exchanges.

@jdambacher
Copy link
Contributor

I've created an adapter for AlphaVantage. It's a free API supporting a lot of currencies, so it's a perfect replacement for the Yahoo adapter. See #55

jdambacher pushed a commit to coffee-bike/LexikCurrencyBundle that referenced this issue Nov 8, 2017
Fixes lexik#54 - lexik:currency:import yahoo not working
@jdambacher
Copy link
Contributor

I think after merging my pull request, this issue can be closed. @ALL Yahoo adapter users: Please use the new AlphaVantage adapter instead.

@devHanane
Copy link

Hello,

Can u please share with us the adapter that you have created. I'm newbie to symfony and I'm using this bundle because my website is multi-currency site. I tried to use ECB but it doesn't contain "MAD" currency of my country. I have created the account in alphavantage but didn"t know where to add code to create custom provider( I have seen the example provided in the doc but I don"t know how to implement it)

@jdambacher
Copy link
Contributor

@devHanane
Unfortunately, my PR is still not merged, but you can check out my fork: https://github.com/coffee-bike/LexikCurrencyBundle

It's fully working with the AlphaAdvantage Adapter

@jdambacher
Copy link
Contributor

jdambacher commented Jul 12, 2018

You just have to add the following to your config.yml:

lexik_currency:  
    currencies:
        default: EUR
        managed: [EUR, CHF, CZK, KWD, RON, GBP, QAR, INR, AED, PLN, TRY, SAR, MKD, HUF]  
    default_adapter: alpha_currency_adapter
    alpha_api_key: '<YOUR API KEY>'

@devHanane
Copy link

Hello,
@jdambacher thanks for ur response. it works. thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants