Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about non-admin (standard user) ? #26

Open
rwasef1830 opened this issue Jun 18, 2020 · 6 comments
Open

What about non-admin (standard user) ? #26

rwasef1830 opened this issue Jun 18, 2020 · 6 comments
Labels
up for grab Extra attention is needed

Comments

@rwasef1830
Copy link

rwasef1830 commented Jun 18, 2020

Hello,
The script works well for admin user, but it fails with non-admin user. It writes some errors and creates the context items but they are non-functional. Running the script as admin, installs the context menu items but for admin only.

Could you make it work for non-admin user as well ?
@lextm

@lextm
Copy link
Owner

lextm commented Jun 18, 2020

It is intentional to require administrator permissions, as one of the Windows Terminal folder is locked down.

@lextm lextm closed this as completed Jun 18, 2020
@lextm lextm added wontfix This will not be worked on and removed wontfix This will not be worked on labels Jun 18, 2020
@lextm lextm reopened this Jun 18, 2020
@rwasef1830
Copy link
Author

Hello,
Can you explain a little bit ? Running Windows terminal doesn't need admin permission! I can run it fine under normal user... why can't the context menu open it as normal user if it is installed by current user from windows store ?

@lextm lextm added the up for grab Extra attention is needed label Jun 18, 2020
@lextm
Copy link
Owner

lextm commented Jun 18, 2020

The function GetProgramFilesFolder accesses the WindowsApps folder,

https://github.com/lextm/windowsterminal-shell/blob/master/install.ps1#L150

That folder can only be read by administrators.

It is possible to modify the install script to skip that folder, but a lot of features won't work then, so I don't plan to work on this.

Pull requests are welcome.

@ghost
Copy link

ghost commented Sep 15, 2021

Related to this question - if I have a main non-admin account (my.name) and a local admin account (my.name2), can I use my admin priveleges to add the context menu for the non-admin user?

@lextm
Copy link
Owner

lextm commented Sep 15, 2021

@p2r2 that requires a very complex mechanism, splitting the install steps to two parts (script files) so that they can be run under two accounts.

While I fully understand that many enterprise users are forced to use two such accounts, it is rather complicated to rewrite the script to achieve that level of control.

Pull requests are welcome though, in case anyone wants to contribute.

@peter1rhodes
Copy link

#50 I have opened a PR for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up for grab Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants