Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column categories for profile picture categories #968

Open
Kevils opened this issue Dec 31, 2024 · 0 comments
Open

Add column categories for profile picture categories #968

Kevils opened this issue Dec 31, 2024 · 0 comments

Comments

@Kevils
Copy link
Collaborator

Kevils commented Dec 31, 2024

Description 📹

Current one :
image
image

New design :
Screenshot 2024-12-31 at 16 24 11
Screenshot 2024-12-31 at 16 24 30
Screenshot 2024-12-31 at 16 24 49

Figma file : https://www.figma.com/design/S1UKYgWewNqNHZFAaBUilG/%F0%9F%8F%9D%EF%B8%8F-Starknet-ID?node-id=4181-26462&t=2s8rQG6hx1hS6Ob1-1

Currently, when trying to modify the profile picture, everything is mixed together and we have to scroll to see all the categories. We need to display everything on a single page without scrolling. To achieve this, a left column should be added (the same one used for purchasing a domain) to separate the categories. The categories should be: first, 'Your NFTs'; second, 'Starknet ID Ecosystem' (which is also available on the PFP collections page: https://app.starknet.id/pfpcollections); and third, 'Overall Starknet Ecosystem'

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    [Insert Code snippet if needed with a mardown todo list]

  3. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant