Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove phpunit PHAR build from Git version control #19

Closed
peter279k opened this issue Sep 16, 2019 · 2 comments
Closed

Remove phpunit PHAR build from Git version control #19

peter279k opened this issue Sep 16, 2019 · 2 comments

Comments

@peter279k
Copy link

As title, the phpunit phar build is about the dependencies of required development.

I think we don't have to let this be in Git version control.

IMHO, the proper way is to remove this PHAR build and define correct phpunit version inside require-dev block on composer.json.

@liamdennehy
Copy link
Owner

@peter279k Did you mean to create this issue here? We were discussing this question in robrichards/xmlseclibs#200

Perhaps you meant to create this in https://github.com/robrichards/xmlseclibs/issues?

@peter279k
Copy link
Author

Ok. Moving the issue to there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants