-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mesh stitcher issue warnings or errors #3580
Comments
Wondering if @jwpeterson has thoughts; I think he wrote most of the mesh stitching code. The case that surprised me recently was when I stitched zero nodes without that throwing an error, but I could easily imagine a new user trying to e.g. stitch an NxN grid to an MxM grid and then being surprised if, for the N!=M case, that results in a slit mesh rather than an error message. |
We do have errors for this, e.g. see It's important to be able to turn that off, though, since in some cases we want to allow the nodes to be "non-conforming" and to instead add constraints to connect the meshes. |
The catch we have is that it's way too common for users to want to stitch a fraction of a boundary - two hexagons, with the same boundary id on the entire boundary of each, but only 1/6th of the one is going to get stitched to 1/6 of the other.
That's the kind of thing I was hoping/fearing to hear! So you might want to get a N->M slit topologically, then, but connect the two solutions in the weak sense only? I guess stitching 0 nodes is even a limiting case of that? So any new error checking along these lines would also need to be optional, and off by default for backwards compatibilty. |
Yes, we allow this, though we typically use "multi-node constraints" to connect any misaligned nodes. This uses constraint-based connections (similar to what we do for "hanging node constraints" in libMesh) rather than "weak enforcement".
Yes, stitching 0 nodes is certainly a relevant case for us. We use the following approach:
|
@roystgnr brought this up during a meeting; when the stitcher tries to stitch two meshes, even though the two side sets to be stitched are not connected, the stitcher will return without any error. For flexibility, we might do not want the two side sets exactly overlap geometrically, but such a case should be considered as a warning or an error. We could also have cases that nodes on one side geometrically within the side set on the other side but do not have any nodes to be merged with. It could be a good idea to issue a warning at the end to tell users that a list of such nodes.
The text was updated successfully, but these errors were encountered: