Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to a more recent version of boost #144

Open
saurik opened this issue May 6, 2021 · 1 comment
Open

upgrade to a more recent version of boost #144

saurik opened this issue May 6, 2021 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@saurik
Copy link

saurik commented May 6, 2021

The version of Boost currently in use by this library is 1.72.0-p1, which is over a year and a half old. FWIW, I've had no issue compiling it with newer versions of Boost--and hadn't even noticed you had locked in such an old version, as I don't use cmake/hunter--until this week, with the release of 1.76.0, which finally removed support for the apparently-long-deprecated older way of using Boost Outcome's macros.

https://www.boost.org/doc/libs/develop/libs/outcome/doc/html/changelog/upgrade_v21_v22.html

As cmake/hunter has in fact been updating to more recent versions of Boost as they come out, I'm honestly not sure exactly what is holding back the version being used by this project (this seems like some kind of secret decision being made by cmake hunter somewhere, maybe due to something buried in a dependency... not that I've so far found anything that looks like such anywhere in any of these projects).

@saurik
Copy link
Author

saurik commented Jul 11, 2021

For anyone else with this issue--projects that wants to use the latest version of boost but also want to build in libp2p--I've had success compiling using a separate copy of outcome pegged at 1.75.0 along with a newer version of the rest of the boost (currently 1.76.0... it is, of course, quite possible that the old version of outcome will eventually break, once again holding back boost).

@dhuseby dhuseby added the help wanted Extra attention is needed label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants