Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yamux newStream does not work #168

Open
igor-egorov opened this issue Sep 20, 2021 · 0 comments
Open

Yamux newStream does not work #168

igor-egorov opened this issue Sep 20, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@igor-egorov
Copy link
Member

igor-egorov commented Sep 20, 2021

There are two versions for new stream creation in cpp-libp2p yamux - sync and async. Async version is not working - we always will have an error "closed by remote peer" when we use it. The actual problem is that the stream is created in both cases, but in the case of the async version, it never returned to the user's callback. The second problem is that the stream creation in both cases is done via the same method under the hood, but in the case of the async approach, we have additional messages on the line, which look unnecessary to be sent over. Thus, the flow seems broken in the case of the async approach of streams creation which is generally preferred.

@dhuseby dhuseby added the help wanted Extra attention is needed label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants