Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reported version is wrong #161

Open
achingbrain opened this issue Sep 28, 2024 · 0 comments
Open

Reported version is wrong #161

achingbrain opened this issue Sep 28, 2024 · 0 comments

Comments

@achingbrain
Copy link
Member

We report the deployed version of the bootstrapper on the dashboard:

image

It's always one version behind the latest npm release, because publishing the docker container takes place in a different GH workflow to publishing the npm module, and you can't make one workflow depend on another.

We solved this problem ages ago for js-ipfs - the js-test-and-release workflow logs us in to a docker registry before calling npm run release, and then we'd do the npm release and the docker push from npm scripts, e.g.:

{
  "scripts": {
    "release": "npm run release:npm && npm run release:docker",
    "release:npm": "... do npm things",
    "release:docker": "... do docker things"
  }
}

Perhaps we should do something similar here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant