Make identify::Config fields private #5660
Labels
Comments
4 tasks
|
@jxs If anyone's not taking this, can I work on it? |
|
thanks @kamuik16! Go for it 😁 |
4 tasks
Already opened a PR for it! |
mergify bot
pushed a commit
that referenced
this issue
Nov 6, 2024
## Description Closes #5660 ## Change checklist - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation - [x] I have added tests that prove my fix is effective or that my feature works - [x] A changelog entry has been made in the appropriate crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
they don't need to be public, we should make it consistent across the project and have them private with getters and setters
Motivation
see #5574 (comment) for more information on the why
NB: We should take advantage of the minor version #5574 introduces and land this with it
Current Implementation
Current implementation has
identify::Configfields publicAre you planning to do it yourself in a pull request ?
Maybe
The text was updated successfully, but these errors were encountered: