Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename repository to interop #109

Open
thomaseizinger opened this issue Jan 19, 2023 · 9 comments
Open

Rename repository to interop #109

thomaseizinger opened this issue Jan 19, 2023 · 9 comments

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Jan 19, 2023

Suggestion to change test-plans to interop-tests everywhere. I think it is more expressive in what these tests are testing.

@MarcoPolo
Copy link
Contributor

Agreed. Lower priority for me, but I like it.

To list what else would have to change:

  • go-libp2p test-plan test (and rename to interop-tests as well)
  • rust-libp2p test-plan test (and rename to interop-tests as well)

@p-shahi
Copy link
Member

p-shahi commented Jan 24, 2023

Does interop-tests cover the scope of planned future tests too? And if we're already testing stuff like expected RTT, maybe it should be e2e-tests

@thomaseizinger
Copy link
Contributor Author

Does interop-tests cover the scope of planned future tests too? And if we're already testing stuff like expected RTT, maybe it should be e2e-tests

Good point, I am okay with e2e-tests too.

@p-shahi
Copy link
Member

p-shahi commented Jun 13, 2023

Is doing this still worthwhile? I think it's a nice distinction to make and allows us to leave test-plans in the past but it also might be harder to pull off with the way testing is embedded in repo

@thomaseizinger
Copy link
Contributor Author

I am almost certain that GitHub creates redirects if you rename a repo. Alternatively, we can just push it under a new name, update all implementation repositories and then delete this one.

@marten-seemann
Copy link
Contributor

Yes, GitHub creates a redirect, I recently went through this process when I migrated quic-go to its own org. It still makes sense to update implementations to use the correct path.

That said, are we getting a lot out of a renaming?

@thomaseizinger
Copy link
Contributor Author

thomaseizinger commented Jun 14, 2023

With the redirect, the good news is that we don't have to do anything in lockstep, thus my point would be that a more expressive name is worth it.

Let's set a deadline for end of June.

Regarding the actual name, what I most commonly hear from people in conversations is interop-tests and not e2e-tests. interop-tests for me suggests that we are testing interoperability whereas e2e-tests has more a focus on testing functionality.

I'd consider hole-punching tests more on the functional side rather than on the interop side.

With the addition of the performance benchmarks, one could even debate whether "tests" is the right category for all of this. Just interop perhaps? Even with the addition of hole-punching tests, I find interop to be a much more intriguing name compared to e2e.

@p-shahi
Copy link
Member

p-shahi commented Jun 22, 2023

interop sounds good to me. Shall we go ahead with the change.

Let's set a deadline for end of June.

That sounds good.

That said, are we getting a lot out of a renaming?

It is cosmetic but why keep referring to test-plans when Testground is no longer used. It also is more evident to newcomers (new implementation adding their interop tests).

@thomaseizinger thomaseizinger changed the title Rename repository to interop-tests Rename repository to interop Sep 28, 2023
@thomaseizinger
Copy link
Contributor Author

interop seems to be already taken by the JS specific interop runner? :/

https://github.com/libp2p/interop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants