perf: rsync everything is brittle

[marten-seemann]

The runner syncs the current state of the directory to the EC2 instances:

test-plans/perf/runner/src/index.ts

Lines 217 to 218 in 0b4e5e4

	const stdout = execCommand(`rsync -avz --progress --filter=':- .gitignore' -e "ssh -o StrictHostKeyChecking=no" ../impl ec2-user@${ip}:/home/ec2-user`);
	console.error(stdout.toString());

This means that if you've built the implementations locally, the binaries will be synced to the server as well. Apparently, these binaries aren't overwritten by the build process, leading to inconsistent state. And, if you're building on a different architecture, those binaries can't be executed.

Possible solutions: Be more careful what to sync to the server. One way to do that could be obtaining the list of files tracked by Git, and only syncing those. Or alternatively, exclude the files ignored by Git, or at the very least blacklist the build outputs.