Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected failure test cases. #96

Open
MarcoPolo opened this issue Jan 3, 2023 · 1 comment
Open

Add expected failure test cases. #96

MarcoPolo opened this issue Jan 3, 2023 · 1 comment

Comments

@MarcoPolo
Copy link
Contributor

    @Jorropo caught a bug in go-libp2p v0.24.0 where a node configured to use Noise could dial a node configured to use TLS (https://github.com/libp2p/go-libp2p/pull/1946)

In a subsequent pull request, we should extend the test cases in here to test the non happy-path (either as a part of the same github action as these or as a separate one that runs as a regression test in a nightly job.)

Originally posted by @p-shahi in #85 (comment)

@marten-seemann
Copy link
Contributor

Agreed that this test would be useful.

It wouldn't have caught the bug that Jorropo found though, that bug was an incorrect error return value, and was fixed by libp2p/go-libp2p#1946.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants