App crashes when downloading a new issue

[libreliodev]

This happened when downloading the last version of Wind, right after the pdf was downloaded. Logcat: https://gist.github.com/libreliodev/ba1ba35e181cccc60bc0
@intrications Can this be related to the update for #208 ?
cc @suntehnik

[intrications]

@libreliodev

I think this is the same crash we were experiencing from before the libmupdf update and not due to #208. This appears to be the same crash: #173 (comment)

Failed to open /data/data/com.niveales.wind/app_librelio/wind_383/wind_383_.pdf

Does this always happen on the same device or have you experienced it on difference devices?

[intrications]

I've added some logging to the download and pushed to github. Can you test a download.

The log just after DownloadManager finishes downloading the pdf should be something like:

downloadMagazineService  D  Download manager says download successful for wind_383/wind_383_.pdf
                        D  Attempting to move file for wind_383/wind_383_.pdf
          StorageUtils  D  move /storage/emulated/0/Android/data/com.niveales.wind/files/wind_383.pdf => /data/data/com.niveales.wind/app_librelio/wind_383/wind_383.pdf
downloadMagazineService  D  5511979 bytes moved for wind_383/wind_383_.pdf

[libreliodev]

@intrications

Does this always happen on the same device or have you experienced it on difference devices?

Just tested on another device, and it did not crash. Will now test again on device where crash occured.

[libreliodev]

@intrications

I've added some logging to the download and pushed to github. Can you test a download.

Tested again, and crashed again: https://gist.github.com/libreliodev/2e7e760eda09db922bfd

And when trying to restart the app, it crashed: https://gist.github.com/libreliodev/122ed7b47181989475f7

[intrications]

@libreliodev

I haven't changed anything that would stop the crash. I'm just trying to work out what is causing the file to not be in the right place after download.

Can you look at the logcat produced on the command line because the crash report does not show the bit that says whether the file was successfully downloaded and copied - the bit that says "Download manager says download successful", etc.

What device are you using and what version of Android is it running?

[libreliodev]

@intrications

Now, I can't reproduce the bug. I keep trying.

[intrications]

What device are you using and what version of Android is it running? Things have changed a bit with dealing with external storage in Android 4.4

[libreliodev]

What device are you using and what version of Android is it running?

Galaxy Tab. Android 4.1.2

[libreliodev]

Just got a new crash not sure wether it's related to push or this issue.

See #173 for context and logcat at https://gist.github.com/libreliodev/dea2d3d41eaaabfa8b40

[libreliodev]

Tried again with another issue, app did not crash, but took a lot of time to complete download.
Logcat: https://gist.github.com/libreliodev/60ba4377ad39c8131160

[intrications]

Ok. I think I've found the problem. For some crazy reason the code didn't check for DownloadMagazine.STATUS_FAILED but would carry on and try to get the assets. Not sure how I didn't notice this before.

I'm not sure why the downloading is failing though. I have pushed code to log the reason code. The logcat will say "STATUS FAILED - REASON CODE:".

I'm thinking again that we should stop using DownloadManager.

[libreliodev]

I'm not sure why the downloading is failing though. I have pushed code to log the reason code. The logcat will say "STATUS FAILED - REASON CODE:".

No way to reproduce the bug again until now.

[libreliodev]

Should be fixed with #231