Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libressl 4.0.0 build failed on mips: crypto_arch.h: No such file or directory #1110

Open
abcfy2 opened this issue Oct 15, 2024 · 4 comments
Open

Comments

@abcfy2
Copy link

abcfy2 commented Oct 15, 2024

Here's the full log of build: https://github.com/abcfy2/aria2-static-build/actions/runs/11342690751/job/31543660613

The reason is:

cp ../../include/arch/mips/opensslconf.h opensslconf.h
make  all-am
make[3]: Entering directory '/usr/src/libressl-4.0.0/include/openssl'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/usr/src/libressl-4.0.0/include/openssl'
make[2]: Leaving directory '/usr/src/libressl-4.0.0/include/openssl'
make[2]: Entering directory '/usr/src/libressl-4.0.0/include'
make[2]: Nothing to be done for 'all-am'.
make[2]: Leaving directory '/usr/src/libressl-4.0.0/include'
make[1]: Leaving directory '/usr/src/libressl-4.0.0/include'
Making all in crypto
make[1]: Entering directory '/usr/src/libressl-4.0.0/crypto'
echo "generating crypto_portable.sym ..."
generating crypto_portable.sym ...
cp ../crypto/crypto.sym crypto_portable.sym
chmod u+w crypto_portable.sym
make  all-am
make[2]: Entering directory '/usr/src/libressl-4.0.0/crypto'
  CC       libcrypto_la-cpt_err.lo
  CC       libcrypto_la-crypto_ex_data.lo
  CC       libcrypto_la-crypto_init.lo
  CC       libcrypto_la-cryptlib.lo
  CC       libcrypto_la-crypto_lock.lo
In file included from crypto_lock.c:22:
crypto_internal.h:23:10: fatal error: crypto_arch.h: No such file or directory
   23 | #include "crypto_arch.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.
  CC       libcrypto_la-cversion.lo
make[2]: *** [Makefile:4714: libcrypto_la-crypto_lock.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/usr/src/libressl-4.0.0/crypto'
make[1]: *** [Makefile:1953: all] Error 2
make[1]: Leaving directory '/usr/src/libressl-4.0.0/crypto'
make: *** [Makefile:460: all-recursive] Error 1
@botovq
Copy link
Contributor

botovq commented Oct 15, 2024

That's a 32-bit mips build, right? In that case, see #1082. If not, we should fix this.

We should probably look into erroring out earlier if people attempt to build this.

@abcfy2
Copy link
Author

abcfy2 commented Oct 15, 2024

That's a 32-bit mips build, right? In that case, see #1082. If not, we should fix this.

We should probably look into erroring out earlier if people attempt to build this.

Yes. It's 32-bit mips. I use this toolchain for cross compile: http://musl.cc/

Today there're some routers may still use mips arch.

@botovq
Copy link
Contributor

botovq commented Oct 15, 2024

Thanks. Yes, I'm aware that the architecture is still in use. As mentioned in the other thread, I'm not against supporting it, but it kind of worked by accident so far. We need someone to step up and own this platform. Otherwise it's simply out of scope for now.

As mentioned in the ChangeLog for 4.0.0: "The mips32 platform is no longer actively supported."

I'll look into making this clearer earlier in the build system.

@hiirotsuki
Copy link
Contributor

v4.0.0 builds and all tests (except year2038) pass on my 32-bit mipsel board w/ debian. Isn't this just about whether or not an architecture has assembly implementations for certain bits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants