Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The assets might be built with wrong runtime #1137

Open
KristianIvarsson opened this issue Jan 22, 2025 · 2 comments
Open

The assets might be built with wrong runtime #1137

KristianIvarsson opened this issue Jan 22, 2025 · 2 comments

Comments

@KristianIvarsson
Copy link

KristianIvarsson commented Jan 22, 2025

The asset libressl_v4.0.0_windows_x64.zip seems to been built with (Runtime Library) /MD but since it is supposed to be a static library, perhaps /MT should be used (otherwise some symbols won't be present)

@joshuasing
Copy link
Member

Hi! The Windows release assets are built by GitHub Actions in this workflow:
https://github.com/libressl/portable/blob/master/.github/workflows/release.yml#L36

I am not too familiar with the Windows build process, however I will have a closer look soon (or if someone else with more knowledge with this could help, that would be great). - Otherwise, if you know how this could be resolved, a pull request would be very helpful and appreciated.

Thanks.

@KristianIvarsson
Copy link
Author

I'd love to help out, but time is limited right now

It looks like you should be able to do set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded") somewhere

Note, some CMAKE-versions seems to have a defect with this though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants