-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Built static link libraries are stripped of debuginfo #247
Comments
Can you share verbose build logs? |
What heuristic is used to detect presence of debuginfo? |
rpmlint validates that |
I can't reproduce this.
|
Side question: Does Fedora build their static libraries with lto enabled? |
Yes it does. LTO is enabled for everything by default. |
If that's the case, doesn't that mean everything is okay? |
My RPM builds seem to indicate no debuginfo?
|
Same with these?
I don't get it, because you're passing
Perhaps the spec files are doing things? I don't think we're doing special things in the CMake script. |
This is what the build phase of the spec file does:
|
As an aside, can we not build a static SDL library? It's actually pretty valuable to be able to upgrade SDL and have installed applications pick up the fixes. |
IIRC, even static SDL will load dynamic SDL if available, but... sure? I'm really only building it because the old SDL2 package had them... |
It seems like the stuff built by CMake has them...
|
Note that even if we have static sdl2-compat, it's still using dynamic SDL3, and we definitely don't recommend or use static SDL for Fedora-built SDL applications. |
Your log contains the following line:
What does that do? |
That script is causing the mischief. In a local build directory, I ran these commands and confirmed a Then I downloaded brp-strip-static-archive, and executed the following in the build directory:
When running the ar and objdump steps again, the debug sections disappeared. Running
Running the following, it shows that it runs
|
@pmatilai, is this what this script is supposed to do? I thought rpm is supposed to do split debuginfo for this, not delete them entirely. |
When building sdl2-compat in Fedora, rpmlint notes that the static link libraries are missing debuginfo:
I'm not sure what's doing this as I'm not doing it.
The text was updated successfully, but these errors were encountered: