Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on Flocking, and rename this library #40

Open
colinbdclark opened this issue May 6, 2022 · 2 comments
Open

Remove the dependency on Flocking, and rename this library #40

colinbdclark opened this issue May 6, 2022 · 2 comments

Comments

@colinbdclark
Copy link
Contributor

flocking-midi currently depends on Flocking because it uses on Flocking's selectbox UI component.

Flocking is unlikely to be upgraded to Infusion 4.x any time soon, and it seems like a dependency that is worth breaking by moving the select box component to a separate repository that can be shared by both libraries (or, gasp, simply duplicating the implementation of the one file in both repositories).

Since this the only relationship today between flocking-midi and Flocking, perhaps we can even come up with a cool name for this library to celebrate its independence.

@duhrer
Copy link
Contributor

duhrer commented May 12, 2022

One option I've been exploring today is to make a UI agnostic component that just tracks the available ports and selected port. This would offer the most options for reusing the core components in other environments, or for transitioning to new renderers, we'd only have to rewrite the UI components.

In addition to a UI agnostic grade, the package should include a viewComponent based setup, perhaps based on the flocking select stuff. I'm imagining this as not exactly a drop-in, but an easy upgrade for those who already use flocking-midi.

I would be willing to put together a pull along these lines to create a new fluid-midi, or to review a pull if you want to put one together.

@colinbdclark
Copy link
Contributor Author

Sure, go for it! Let me know how I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants