-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Signaletic's clock detection algorithms #66
Comments
colinbdclark
added a commit
to colinbdclark/signaletic
that referenced
this issue
Nov 19, 2023
…ator. lichen-community-systemsgh-66: Simplifies ClockDetector for greater reliability. Improves Dusting example.
colinbdclark
added a commit
to colinbdclark/signaletic
that referenced
this issue
Nov 20, 2023
colinbdclark
added a commit
to colinbdclark/signaletic
that referenced
this issue
Nov 25, 2023
colinbdclark
added a commit
to colinbdclark/signaletic
that referenced
this issue
Nov 25, 2023
… Ensures all array access is wrapped.
Fixed in #68. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, Signaletic's
sig_dsp_ClockFreqDetector
(and the Daisy-based hardware examples that use it) is not particularly accurate, largely because of the lowpass filtering done to incoming clock signals.After reading more about the problem, it seems simpler is better. Most simply use two clock pulses in a row to calculate tempo, with no smoothing or averaging. Sometimes an exponential moving average of multiple clock pulses can be useful (when tempo is tapped manual) but in practice a simple non-averaging calculation is probably best.
The text was updated successfully, but these errors were encountered: