Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lila should not be catching general Exceptions #16137

Open
isaacl opened this issue Sep 28, 2024 · 1 comment
Open

lila should not be catching general Exceptions #16137

isaacl opened this issue Sep 28, 2024 · 1 comment

Comments

@isaacl
Copy link
Member

isaacl commented Sep 28, 2024

As exemplified by impl of scala.util.Try, our try catches should not be catching general Exception class. This includes InterruptedException which it's unlikely we want to suppress.

We should replace instances of catch case e: Exception => with

catch case scala.util.control.NonFatal(e) =>

or a more specific exception if available.

@lenguyenthanh
Copy link
Member

Agree, another option in our hands is Either.catchNonFatal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants