Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on initial cake build due to missing dist folder #107

Open
maximerassi opened this issue May 13, 2023 · 2 comments
Open

Failure on initial cake build due to missing dist folder #107

maximerassi opened this issue May 13, 2023 · 2 comments
Labels
bug Issues describing a bug or pull requests fixing a bug.

Comments

@maximerassi
Copy link

Describe the bug

On a first-time clone, dotnet cake fails due to missing folder "Frontend/dist"
https://github.com/ligershark/dotnet-new-ui/blob/main/build.cake#LL10C41-L10C42

Steps to reproduce

  1. Clone
  2. Run dotnet cake

Expected behaviour

Proposed Fix

  1. add .gitignore under Frontend/dist
  2. update Frontend/.gitignore with
/dist
!/dist/.gitignore
@maximerassi maximerassi added the bug Issues describing a bug or pull requests fixing a bug. label May 13, 2023
@RehanSaeed
Copy link
Collaborator

RehanSaeed commented May 16, 2023

Thanks for raising. I'd accept a PR to fix this if you're interested.

@RehanSaeed
Copy link
Collaborator

There is a guide below on how to submit a pull request if you're interested. You first have to create a fork of this repo, make the change in a branch on your form and then submit a pull request from the branch on the fork.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues describing a bug or pull requests fixing a bug.
Projects
None yet
Development

No branches or pull requests

2 participants