From 7c81277cf179198cd970d53fc09a6c4f1dee30ad Mon Sep 17 00:00:00 2001 From: Scala Steward Date: Tue, 4 Jun 2024 16:08:22 +0000 Subject: [PATCH 1/3] Applied Scalafix rule(s) dependency:Collection213Upgrade@org.scala-lang.modules:scala-collection-migrations:2.8.1 See https://github.com/scala/scala-collection-compat#collection213upgrade for details --- core/src/main/scala/com/lightbend/benchdb/RunResult.scala | 2 +- core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/com/lightbend/benchdb/RunResult.scala b/core/src/main/scala/com/lightbend/benchdb/RunResult.scala index b1e2bfe..3e0d144 100644 --- a/core/src/main/scala/com/lightbend/benchdb/RunResult.scala +++ b/core/src/main/scala/com/lightbend/benchdb/RunResult.scala @@ -227,7 +227,7 @@ object RunResult extends Logging { class ParamOrdering(paramTypes: Seq[(Boolean, Boolean)], nullsFirst: Boolean = false) extends Ordering[Seq[String]]{ def compare(x: Seq[String], y: Seq[String]): Int = { - val it = (x, y, paramTypes).zipped.toIterator + val it = x.lazyZip(y).lazyZip(paramTypes).iterator while(it.hasNext) { val (x, y, (asLong, asDouble)) = it.next() if(x != null || y != null) { diff --git a/core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala b/core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala index fde1828..aea30f8 100644 --- a/core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala +++ b/core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala @@ -10,7 +10,7 @@ class TableFormatter(val go: GlobalOptions) { import TableFormatter._ import go.format._ - protected[this] def formatLine(line: IndexedSeq[Any], formats: IndexedSeq[Format]): IndexedSeq[Cell] = (line, formats).zipped.map { (v, c) => + protected[this] def formatLine(line: IndexedSeq[Any], formats: IndexedSeq[Format]): IndexedSeq[Cell] = line.lazyZip(formats).map { (v, c) => def fmtSimple(v: Any): String = v match { case null => "" case Some(v) => fmtSimple(v) From 22b51d00b49cf9961b2ca7cd794103ee205d3c97 Mon Sep 17 00:00:00 2001 From: Scala Steward Date: Tue, 4 Jun 2024 16:08:22 +0000 Subject: [PATCH 2/3] Update scala-library to 2.13.14 --- build.sbt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index f96d8e3..4fce934 100644 --- a/build.sbt +++ b/build.sbt @@ -4,7 +4,7 @@ lazy val root = project.in(file(".")) .settings(inThisBuild(Seq( organization := "com.lightbend.benchdb", //version := "0.1-SNAPSHOT", - scalaVersion := "2.12.19", + scalaVersion := "2.13.14", scalacOptions ++= Seq("-deprecation", "-unchecked"), ))) .settings( @@ -42,6 +42,7 @@ lazy val plugin = project.in(file("plugin")) .settings( name := "sbt-benchdb", sbtPlugin := true, + scalaVersion := "2.12.19", buildInfoKeys := Seq[BuildInfoKey](organization, core / name, version, core / scalaVersion), buildInfoPackage := "com.lightbend.benchdb.sbtplugin", publishMavenStyle := false, From 2c782c54a53ca997177ed67cf8b7d0f00f432da2 Mon Sep 17 00:00:00 2001 From: Seth Tisue Date: Tue, 4 Jun 2024 11:18:51 -0500 Subject: [PATCH 3/3] source tweaks for Scala 2.13 --- core/src/main/scala/com/lightbend/benchdb/RunResult.scala | 2 +- core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/com/lightbend/benchdb/RunResult.scala b/core/src/main/scala/com/lightbend/benchdb/RunResult.scala index 3e0d144..f529ad0 100644 --- a/core/src/main/scala/com/lightbend/benchdb/RunResult.scala +++ b/core/src/main/scala/com/lightbend/benchdb/RunResult.scala @@ -237,7 +237,7 @@ object RunResult extends Logging { val diff = Ordering.Long.compare(x.toLong, y.toLong) if(diff != 0) return diff } else if(asDouble) { - val diff = Ordering.Double.compare(x.toDouble, y.toDouble) + val diff = Ordering.Double.TotalOrdering.compare(x.toDouble, y.toDouble) if(diff != 0) return diff } else { val diff = Ordering.String.compare(x, y) diff --git a/core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala b/core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala index aea30f8..03b363a 100644 --- a/core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala +++ b/core/src/main/scala/com/lightbend/benchdb/TableFormatter.scala @@ -83,7 +83,7 @@ class TableFormatter(val go: GlobalOptions) { } } } - widths + widths.toIndexedSeq } private def formatSeparator(widths: IndexedSeq[Int], lIdx: Int, cIdx: Int, rIdx: Int): String = {