Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rebalance plugin #502

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix rebalance plugin #502

merged 1 commit into from
Mar 12, 2024

Conversation

gallizoltan
Copy link
Collaborator

rebalance plugin is maintained

@sip-21
Copy link
Collaborator

sip-21 commented Mar 5, 2024

Hi @gallizoltan , there seems to be an issue with the CI tests for PRs moving a plugin out of the archived directory. Will investigate asap.

@sip-21
Copy link
Collaborator

sip-21 commented Mar 7, 2024

@gallizoltan Once #503 is merged you can move ahead with this PR. According to this workflow run (which I used for testing my CI workflow changes ) the rebalance plugin tests won't pass yet, though.

@cdecker
Copy link
Contributor

cdecker commented Mar 7, 2024

Merged #503 👍

@gallizoltan
Copy link
Collaborator Author

@sip-21 I'm working on the rebalance tests. Besides, are you sure #503 helps? As I see, the integration tests still cannot find the rebalance directory here.

@chrisguida
Copy link
Collaborator

Looks like the problem may be that your branch is named master... @sip-21 can we work around this?

https://github.com/lightningd/plugins/actions/runs/8202656311/job/22433872620?pr=502#step:8:146

@chrisguida chrisguida mentioned this pull request Mar 9, 2024
Merged
@chrisguida
Copy link
Collaborator

Please rebase on #506 and make sure CI passes

@gallizoltan gallizoltan marked this pull request as ready for review March 11, 2024 14:09
@gallizoltan
Copy link
Collaborator Author

@chrisguida @sip-21 I've made the rebase, checks have passed, please review, I think it is ready for merge! 😎

@chrisguida
Copy link
Collaborator

ACK 4a87751

@chrisguida chrisguida merged commit 83a80d1 into lightningd:master Mar 12, 2024
7 checks passed
@chrisguida
Copy link
Collaborator

Thanks again @gallizoltan for fixing rebalance! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gallizoltan @sip-21 @cdecker @chrisguida