Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route blinding: use all valid routes during path construction iteration instead of the currently capped set #9076

Open
ellemouton opened this issue Sep 9, 2024 · 0 comments
Labels
blinded paths bug Unintended code behaviour

Comments

@ellemouton
Copy link
Collaborator

Today, if we are constructing set of blinded payment paths to add to an invoice, we:

  1. Select up to MaxNumPaths routes to our own node that are considered blinded path candidates.
  2. This set is then passed to blindedpath.BuildBlindedPaymentPaths which attempts to use each path to build a valid blinded path
  3. If blindedpath.BuildBlindedPaymentPaths finds that it cannot use one of the paths it was given, it skips it and moves on to the next one

This order of operations means that we may run out of paths in blindedpath.BuildBlindedPaymentPaths and we wont go back and try some of the paths that we initially found by ChannelRouter's findBlindedPaths .

What we instead want is for blindedpath.BuildBlindedPaymentPaths to be able to continue with the iteration through possibly all of the routes found in findBlindedPaths until it reaches the max specified by MaxNumPaths.

@ellemouton ellemouton added enhancement Improvements to existing features / behaviour blinded paths bug Unintended code behaviour and removed enhancement Improvements to existing features / behaviour labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blinded paths bug Unintended code behaviour
Projects
None yet
Development

No branches or pull requests

1 participant