Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore test with max_query_count: 1 #606

Open
alexislefebvre opened this issue May 18, 2022 · 0 comments
Open

Restore test with max_query_count: 1 #606

alexislefebvre opened this issue May 18, 2022 · 0 comments

Comments

@alexislefebvre
Copy link
Collaborator

alexislefebvre commented May 18, 2022 •
edited
Loading

One test of AllowedQueriesExceededException and some other things were broken on the main branch, I fixed these issues in another PR: #604 I'm not happy with the change of max_query_count from 1 to 0 in the internal tests but if it allow to have a version compatible with Symfony 6, it will be worth it.

Originally posted by @alexislefebvre in #598 (comment)

Here is the related commit: 93a080a

It looks like the queries to database are not counted properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexislefebvre