Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S3 reliability] Use FileBackedOutputStream to back SecondaryBlobStore::save #1232

Open
quantranhong1999 opened this issue Oct 14, 2024 · 0 comments
Labels
customer enhancement New feature or request

Comments

@quantranhong1999
Copy link
Member

Why

Indeed we are forced to copy the inputstream as the two daos can't read the inputStream.

However  IOUtils.toByteArray(inputStream) operation is blocking: please to it onto a Scheduler.boundedElastic()...

Moreover this API might be called with objects that might not fit in memory. I would welcome the use of FileBackedOutputStream that uses a file if the input is > 100MB.

cf https://github.com/linagora/tmail-backend/pull/1214/files#r1791802833

DoD

Finish the TODO:

@quantranhong1999 quantranhong1999 added customer enhancement New feature or request labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant