From 9cef74ac1fdf9a59758982d5396efcd6aa849a21 Mon Sep 17 00:00:00 2001 From: yupyup-kim Date: Tue, 12 Mar 2024 16:17:32 +0900 Subject: [PATCH] fix: validateEvent on webhook --- .../src/domains/admin/project/webhook/webhook.service.ts | 7 +------ .../feedback-issue/feedback-issue-statistics.service.ts | 2 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/apps/api/src/domains/admin/project/webhook/webhook.service.ts b/apps/api/src/domains/admin/project/webhook/webhook.service.ts index b6e409008..c67a39307 100644 --- a/apps/api/src/domains/admin/project/webhook/webhook.service.ts +++ b/apps/api/src/domains/admin/project/webhook/webhook.service.ts @@ -61,7 +61,7 @@ export class WebhookService { EventTypeEnum.ISSUE_STATUS_CHANGE, ].includes(event.type) ) { - return !event.channelIds; + return !event.channelIds || event.channelIds.length === 0; } return false; @@ -103,11 +103,6 @@ export class WebhookService { }); return await this.repository.save(newWebhook); - - // const savedEvents = await this.eventRepo.save(events); - // savedWebhook.events = savedEvents; - - // return savedWebhook; } async findById(webhookId: number) { diff --git a/apps/api/src/domains/admin/statistics/feedback-issue/feedback-issue-statistics.service.ts b/apps/api/src/domains/admin/statistics/feedback-issue/feedback-issue-statistics.service.ts index 70b790148..61990f135 100644 --- a/apps/api/src/domains/admin/statistics/feedback-issue/feedback-issue-statistics.service.ts +++ b/apps/api/src/domains/admin/statistics/feedback-issue/feedback-issue-statistics.service.ts @@ -116,7 +116,9 @@ export class FeedbackIssueStatisticsService { where: { id: projectId }, }); const timezoneOffset = timezone.offset; + const cronHour = (24 - Number(timezoneOffset.split(':')[0])) % 24; + const job = new CronJob(`2 ${cronHour} * * *`, async () => { if ( await this.schedulerLockService.acquireLock(