Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swash_render not rendering on main #114

Closed
waywardmonkeys opened this issue Sep 9, 2024 · 3 comments · Fixed by #115
Closed

swash_render not rendering on main #114

waywardmonkeys opened this issue Sep 9, 2024 · 3 comments · Fixed by #115

Comments

@waywardmonkeys
Copy link
Contributor

@dfrg In 14070d5 (PR #106), you had this in your changes:

--- a/examples/swash_render/src/main.rs
+++ b/examples/swash_render/src/main.rs
@@ -80,7 +80,6 @@ fn main() {
     let mut layout: Layout<Color> = builder.build();

     // Perform layout (including bidi resolution and shaping) with start alignment
-    layout.break_all_lines(max_advance);
     layout.align(max_advance, Alignment::Start);

     // Create image to render into

That wasn't done to the tiny_skia_render example and after this commit, the tiny_skia_render example still renders, but the swash_render does not.

Restoring this line appears to let things still work...

Should this line be added back in? Should something else be fixed? Should the tiny_skia_render example be updated in some similar way if this change remains in place?

@waywardmonkeys
Copy link
Contributor Author

I found this while trying to validate that dfrg/swash#61 didn't break anything...

@nicoburns
Copy link
Contributor

Should this line be added back in?

I'm pretty sure it should. I'm surprised CI didn't catch this!

@waywardmonkeys
Copy link
Contributor Author

I'll submit a PR for it shortly.

waywardmonkeys added a commit to waywardmonkeys/parley that referenced this issue Sep 12, 2024
This line may have been mistakenly removed in linebender#106
(14070d5).

Fix linebender#114.
github-merge-queue bot pushed a commit that referenced this issue Sep 12, 2024
This line may have been mistakenly removed in #106
(14070d5).

Fix #114.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants