You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that HtmlButtonElement has a disabled helper method for setting the disabled state, but that, for example, HtmlIFrameElement doesn't have a src helper method for setting the <iframe>src attribute. Is it desired to have such helper methods? If so, I'd be happy to submit a PR.
The text was updated successfully, but these errors were encountered:
Yeah that's actually the plan, and I'm happy for PRs implementing this, e.g. the HtmlImageElement does have src already, currently just wrapping Attr is fine. Ideally this should access the DOM attributes directly of the underlying element, but I have concerns regarding the resulting binary size with the code that's necessary for this (which is why there's a commented out feature gate above those traits).
I noticed that
HtmlButtonElement
has adisabled
helper method for setting the disabled state, but that, for example,HtmlIFrameElement
doesn't have asrc
helper method for setting the<iframe>
src
attribute. Is it desired to have such helper methods? If so, I'd be happy to submit a PR.The text was updated successfully, but these errors were encountered: