Review webextension-polyfill usages

[hugolpz]

As I dived back into the code and its maintenance I'm remembering of :

• npmjs: https://npmjs.com/package/webextension-polyfill
• github: https://github.com/mozilla/webextension-polyfill

We have it installed in the packgage.json, but I think it is not properly imported accorss the web-extension.

Ways to load polyfill

See Basic Setup

• In Manifest.json
• In .js content scripts
• In popup.html

Resources

• Cross-platform extension coding hurdles#The WebExtension browser API Polyfill
• Errors using webextension-polyfill to make a cross-browser add-on

[kabir-afk]

Well I can't seem to remember where I read it but as far as I remember...it was something about callbacks and promises with relation to previous manifest version (MV2). In MV2 chrome used callbacks while other browsers supported promises...but now that promise support is added , I said that the we no longer have to use webExtension polyfill API. But upon understanding more of the extension and reading more docs , I realized that we do need polyfills for cross browser compatibility.

As far as the issue is concerned then in the PR#63 I commnetd out the polyfill library inside my popup.js , so that might be the reason why it isn't imported properly.

[kabir-afk]

Can I mention one other thing ? When uncommenting the polyfill library inside popup.js , it throws error background page is missing or something like that. And this was also the reason I kept it commented out.